[wp-trac] [WordPress Trac] #21113: Previous/Next page links maintain all GET variables
WordPress Trac
noreply at wordpress.org
Fri Apr 5 11:33:00 UTC 2013
#21113: Previous/Next page links maintain all GET variables
-------------------------------------+------------------------------
Reporter: kirrus | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 3.4
Severity: normal | Resolution:
Keywords: needs-patch 2nd-opinion |
-------------------------------------+------------------------------
Changes (by crazycoders):
* cc: crazycoders (added)
* keywords: needs-patch => needs-patch 2nd-opinion
* type: defect (bug) => enhancement
* severity: critical => normal
Comment:
I suggest to only keep variables that wordpress requires to work with but
add a filter if there isn't one yet so the user/plugins can supplement
more parameters if need be. Always remember that someone might actually
need that query parameter ABC that was originaly passed on.
I'll check the core this weekend to see how i can submit a patch regarding
this.
Note that a modification of this nature will break existing plugins and
themes that rely on that buggy feature and thus will probably not be
merged before a few cycles until everyone gets notified about it.
I might actually suggest two patches, one to add the filter first (If it
doesn't exist yet) which will do no harm but offer an immediate response
to all developpers and then in a later cycle, we can introduce the fix
that will break plugins and themes that still rely on it and haven't
changed their methods to the new one.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/21113#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list