[wp-trac] [WordPress Trac] #23931: wp_insert_comment should require comment_post_ID
WordPress Trac
noreply at wordpress.org
Wed Apr 3 19:06:08 UTC 2013
#23931: wp_insert_comment should require comment_post_ID
--------------------------+------------------------------
Reporter: markoheijnen | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Comments | Version:
Severity: normal | Resolution:
Keywords: needs-patch |
--------------------------+------------------------------
Description changed by markoheijnen:
Old description:
> At this moment there is no check for example comment_post_ID. Not sure if
> there are more checks needed. Reason I asked are a few notices on the
> unit tests caused by WP_UnitTest_Factory_For_Comment. Those comments
> don't add a post ID what should change.
New description:
At this moment there is no check for example comment_post_ID. Not sure if
there are more checks needed. Reason I asked are a few notices on the unit
tests caused by WP_UnitTest_Factory_For_Comment. Those comments don't add
a post ID what should change.
Currently, if a null comment_post_ID is passed, the comment isn't
connected to a post. This can create confusion. Also Unit tests should run
with WP_Debug on.
--
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23931#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list