[wp-trac] [WordPress Trac] #23868: Twenty Eleven: Multiple search forms should increment ids

[WordPress Trac]

#23868: Twenty Eleven: Multiple search forms should increment ids
---------------------------+------------------------------
 Reporter:  WraithKenny    |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+------------------------------

Comment (by WraithKenny):

 @obenland: it wouldn't be completely unstyled. They'd still get all
 general styles, and styles inherited via class name (with 23868-4). Any
 child theme that didn't target the duplicated IDs and any child theme that
 copied the searchform template, wouldn't be affected at all.

 @MikeHansenMe: It is true that the hypothetical style you describe would
 no longer be applied. This is an error in the theme's css though. (I would
 not have thought that any theme would do such a thing, but core's own
 default did.) The problem is, that we shouldn't avoid fixing a bug in
 order to prevent some small style degradation.

 While its always been wrong to use duplicate ids for various reasons (best
 practice, validation, JavaScript compatibility, over-weighted specificity,
 etc.), I've come across another reason: "duplicate ID errors are known to
 cause problems for assistive technologies"
 http://www.w3.org/TR/WCAG20-TECHS/F77.html .

 Many sites (government) require WCAG validation by law. Luckily for them,
 the online scanning software almost always miss these errors, so they
 don't know that they aren't in compliance (I won't tell if you don't). And
 perhaps I'm somehow misreading the requirement (it's been known to
 happen).

 Having said that, at least core has fix it by default, so the severity is
 lessened somewhat. It's now possible for sites wishing to clear up this
 error can switch to a different theme. New themes created from WP v3.6
 forward will never style these duplicate IDs again (unless they follow
 TwentyEleven's bad example).

 I'll leave it to others as to whether to close this bug as "wontfix". I,
 Of course, feel that it should be fix.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23868#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software