[wp-trac] [WordPress Trac] #23901: Revisions: revisions.js clean up

[WordPress Trac]

#23901: Revisions: revisions.js clean up
--------------------------+--------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  Revisions     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+--------------------
Changes (by adamsilverstein):

 * cc: adamsilverstein@… (added)


Comment:

 thank you for your effort at cleaning up the code, its definitely getting
 better!

 i did a little testing and found a few problems, not sure of the source
 but i can try to dig a little deeper into the code to see whats happening.

 here is what i saw:
  * in single handle mode, the Restore button should be hidden when the
 handle is in the right most position - the current revision; it doesn't
 make sense to restore the current revision so the button is hidden.
 everything else in the single handle mode seems fine.

  * in the two handled mode there is an issue with the left handle which
 seems to be stuck showing [Current Revision]; when dragging the left
 handle the 'To:' part changes when only the 'From:' part should change; it
 looks like the ajax data calls are off, i see right_handle_at=0 in both
 initial two handled calls, one should not have this variable at all, one
 should have right_handle_at=[wherever the handle is at]; something is
 broken with the url. if i discover more i will contribute to your branch
 on github

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23901#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software