[wp-trac] [WordPress Trac] #16215: Post Revision history displays the incorrect author

WordPress Trac noreply at wordpress.org
Tue Apr 2 01:11:06 UTC 2013


#16215: Post Revision history displays the incorrect author
-------------------------------------+-----------------------
 Reporter:  mdawaffe                 |       Owner:  westi
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  3.6
Component:  Revisions                |     Version:  2.6
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |
-------------------------------------+-----------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I have two feelings about _wp_upgrade_revisions_of_post():

  * It's actually a bit heavy. It seems to run on every admin edit, and
 causes queries for revisions and some other execution, even after a post
 has been upgraded.

  * It runs in a fairly random place. Couldn't it run in wp_insert_post(),
 possibly just as part of wp_save_post_revision()?

 The locking is kind of weird, but I get its necessity.

 mdawaffe, what do you think of the final code?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16215#comment:82>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list