[wp-trac] [WordPress Trac] #21101: Allow get_comments() to query for explicit value of comment_approved

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 28 20:21:41 UTC 2012


#21101: Allow get_comments() to query for explicit value of comment_approved
-------------------------+-----------------------
 Reporter:  nbachiyski   |       Owner:  westi
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  3.5
Component:  Comments     |     Version:  3.4
 Severity:  blocker      |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Comment (by Otto42):

 Agreed, but if you change the meaning of all in this case, you're breaking
 backward compatibility. People might wonder why their spam or trashed
 comments suddenly show up in the "all" listing after upgrading.

 Also, a lot of places in core use that "all" thing. Changing all of them
 to have more sane behavior might take a while. Could be something to put
 on the list for 3.6, mind you.

 But right now, trunk (and Beta-1) is broken and not showing any comments
 on the main admin Comments page.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21101#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list