[wp-trac] [WordPress Trac] #21789: Twenty Twelve as default theme

WordPress Trac wp-trac at lists.automattic.com
Thu Sep 27 12:05:05 UTC 2012


#21789: Twenty Twelve as default theme
---------------------------+-----------------------
 Reporter:  markoheijnen   |       Owner:  dd32
     Type:  enhancement    |      Status:  assigned
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+-----------------------

Comment (by dd32):

 > Also, Twenty Twelve is going to be 1.0 before 3.5, and available for 3.4
 installs. We should make sure we do install it with 3.5 if it doesn't
 exist, but don't upgrade it if it does.

 This should be the case already. We have a check for it `if (
 $wp_filesystem->is_dir($dest . $filename) ) continue;`
 [http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/update-
 core.php#L701 here].

 > I don't think the beta tester plugin is currently installing or updating
 Twenty Twelve. We should make sure it can with these changes.

 Upgrading using the builtin upgrader will NOT be upgrading the bundled
 theme or plugins, thoughts: (for before beta 2)
 1. Core should detect that either old, or new version is an non-stable
 release (nacin suggests existence of a dash in version number), and in the
 event of that, force overwrites of bundled items.
 1. Add a filter around the skip, defaulting to the current existance
 checks, to allow for plugins (beta tester) to force overwrites - although
 point 1 would probably cover this.. there's no harm in adding the filter?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21789#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list