[wp-trac] [WordPress Trac] #21951: Twenty Twelve: add post_type_archive_title to archive.php

WordPress Trac wp-trac at lists.automattic.com
Thu Sep 27 06:56:42 UTC 2012


#21951: Twenty Twelve: add post_type_archive_title to archive.php
---------------------------+-----------------------
 Reporter:  thomask        |       Owner:
     Type:  enhancement    |      Status:  reopened
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+-----------------------

Comment (by nacin):

 The debate in IRC was spirited. To the core team, I half-jokingly said I
 want a conversation like that every week. I should be careful what I wish
 for, I suppose, but on the other hand, needing to make a decision is
 exactly the purpose of our dev chats. If there's no discussion to settle a
 disagreement, it might as well be a blog post rather than a meeting.

 Unfortunately, the dev chat could not come to an agreement. I can't
 remember the last time that happened quite like this. The core team talked
 it over. I asked Matt to make the call. After laying out both sides for
 him — he also read the logs — it was decided we'll be adding these
 templates.

 It was also noted that since Twenty Ten had them and Twenty Eleven didn't,
 maybe Twenty Thirteen should go with the block of conditionals again. (I
 kid, kind of.)

 I'm going to compromise a bit here. Since the proposed date.php still has
 a conditional block of is_day(), is_year(), and is_month(), I'm going to
 keep that in archive.php. Date-based archives is also more obviously an
 "archive" than categories or tags. (It's a shame we don't bother with
 hours, minutes, or seconds in our template!) That means we'll have
 category.php and tag.php, which each have specific description blocks that
 most concerned me in archive.php.

 I'll also be converting any uses of brackets in templates to if/endif
 alternative style, as brackets can get lost (and spelling it out is more
 teachable, less cryptic). I had done it in date.php, but Matt actually
 pointed this out in particular.

 I'm also going to shelve taxonomy.php, as post format archives haven't
 taken off yet (and Twenty Twelve doesn't link to them). Those too will
 fall back to archive.php, as will post type archives. Those are best left
 to a child theme for now.

 If I proposed this in IRC, I have a feeling both sides would have
 capitulated. Alas, time to move on. We got a theme to ship.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21951#comment:34>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list