[wp-trac] [WordPress Trac] #22000: "Reply and Approve" should approve parent comment first

[WordPress Trac]

#22000: "Reply and Approve" should approve parent comment first
----------------------------------+------------------------------
 Reporter:  nacin                 |       Owner:
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  Awaiting Review
Component:  Comments              |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  needs-patch easy-fix  |
----------------------------------+------------------------------
Description changed by nacin:

Old description:

> "Reply and Approve" should approve parent comment first. If you receive a
> stream of updates (emails, jabber, etc.), you'd end up with the comments
> out of order.
>
> Fairly simple fix — take the block that starts with "// automatically
> approve parent comment" and move it above the wp_new_comment() call.
>
> If for some reason wp_new_comment() fails (as we account for currently,
> minimally), we should probably just let the parent comment stand as
> approved, no need to try to revert.

New description:

 "Reply and Approve" should approve parent comment first. If you receive a
 stream of updates (emails, jabber, etc.), you'd end up with the comments
 out of order.

 Fairly simple fix — take the block in wp_ajax_replyto_comment() that
 starts with "automatically approve parent comment" and move it above the
 wp_new_comment() call.

 If for some reason wp_new_comment() fails (as we account for currently,
 minimally), we should probably just let the parent comment stand as
 approved, no need to try to revert.

--

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22000#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software