[wp-trac] [WordPress Trac] #21456: Replace animated spinner gifs

[WordPress Trac]

#21456: Replace animated spinner gifs
----------------------------+------------------------
 Reporter:  nacin           |       Owner:  lessbloat
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  3.5
Component:  UI              |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------------

Comment (by nacin):

 The reason why visibility: hidden is often used instead of display: none
 is because then the spinner takes up space. When toggling the display
 property, we've often seen other objects move around, which can be jarring
 and certainly not expected behavior. So it is definitely safer to use
 visibility.

 I'd like to do either a 'visible' class or an 'active' class. Then show()
 and hide() can be add/toggle/removeClass. Better then css('visibility',
 value), that's for sure.

 Looking at [attachment:21456.3.diff], I'm seeing a lot of brokenness. Not
 your fault — we basically rolled our own spinner code for quite a long
 time. This is unfortunately way more than just a find-and-replace
 operation. Also, the spinners on options-general.php aren't unused.

 I suggest we introduce .spinner, then start to use it wherever we can.
 Each instance will need to be confirmed (which is not fun or easy) as
 being not broken style-wise. A decent amount of CSS classes (.waiting,
 .ajax-loading) can probably vanish, and some JS could probably be cleaned
 up.

 Also, the nice thing about .spinner is it also allows us to direct a media
 query at wpspin_light.gif for the 2x spinner.

 @lessbloat: Perhaps we can get someone else to pick this up so we don't
 get sucked into this much further.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21456#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software