[wp-trac] [WordPress Trac] #21980: Themes without Options when being activated hide all other Theme screenshots.

[WordPress Trac]

#21980: Themes without Options when being activated hide all other Theme
screenshots.
-----------------------------+--------------------------
 Reporter:  sterlo           |       Type:  defect (bug)
   Status:  new              |   Priority:  normal
Milestone:  Awaiting Review  |  Component:  Themes
  Version:  trunk            |   Severity:  minor
 Keywords:                   |
-----------------------------+--------------------------
 This is caused by some IF logic being slightly off.

 Basically - Line #203 of wp-admin/themes.php needs to be moved to #201 -
 just above the closing div.

 It's just excluding the closing DIV for themes without options.
 Problem is apparent if you created a theme with a minimal stylesheet and
 empty index.php file and then activated it. You should see all the default
 WordPress themes have their thumbnails hidden.

 The commit that introduced the issue:

 GIT:
 https://github.com/WordPress/WordPress/commit/98b61d9a171ffafbcc33305e30568462480d238c#L4R194

 SVN: http://core.svn.wordpress.org/!svn/bc/21010/trunk/wp-admin/themes.php

 Here's the DIFF of the fix:

 {{{
 diff --git a/wp-admin/themes.php b/wp-admin/themes.php
 index 5e83da8..5b56fd7 100644
 --- a/wp-admin/themes.php
 +++ b/wp-admin/themes.php
 @@ -198,9 +198,9 @@ $customize_title = sprintf( __( 'Customize
 “%s”' ), $ct->display('Na
                                 <li><?php echo $option; ?></li>
                         <?php endforeach; ?>
                 </ul>
 +               <?php endif; // options ?>
         </div>
         <?php
 -               endif; // options
         endif; // options || edit_theme_options
         ?>
 }}}

 I don't think a patch is needed.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21980>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software