[wp-trac] [WordPress Trac] #21391: Move attachment editing (media.php) to use standard post type UI

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 21 23:11:36 UTC 2012


#21391: Move attachment editing (media.php) to use standard post type UI
----------------------------+------------------
 Reporter:  nacin           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.5
Component:  Media           |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by nacin):

 Some things on the to-do:

  * We need proper messages in post.php, for those that apply, to replace
 my array_fill().

  * Some of the get_post_status() checks make sense. But, if you upload an
 attachment to a draft post, that attachment page is publicly accessible.
 Don't really want to get into whether it *should* be publicly accessible,
 but since it is, "View Attachment Page" should be visible.

  * On the same vein, I had to make a change from the patches in [21948]
 from name=publish on the submit button to name=save so everything worked.
 We need a full post status audit — what happens when an attachment is
 status X, Y, Z, what happens when its parent is X, Y, Z. Are messages
 right? Cap checks right? Save buttons proper? etc.

  * Dissolve media.php. Figure out what we need out of there (including
 help), and otherwise, kill it.

  * media-new.php shows the old form. (Keep in mind it allows for multiple
 uploads at once.) What should this workflow be? I don't know yet.

  * Fully test cropping. Fully test taxonomies and edit-tags.php
 integration (figure out if we should force _update_generic_term_count).

  * The "Add New" button needs an upload_files check. This is probably time
 for a create_posts meta cap. I've moved #16714 to 3.5.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21391#comment:37>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list