[wp-trac] [WordPress Trac] #20759: Implement set_url_scheme() where appropriate

[WordPress Trac]

#20759: Implement set_url_scheme() where appropriate
-------------------------------------+-----------------------
 Reporter:  johnbillion              |       Owner:  ryan
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  3.5
Component:  General                  |     Version:  3.4
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+-----------------------
Changes (by SergeyBiryukov):

 * type:  defect (bug) => enhancement


Comment:

 The ticket itself is still an enhancement.

 Replying to [comment:15 mindctrl]:
 > It strips out the https and instead of linking https://domain.com it
 only links domain.com (no http* - only relative).

 I could not reproduce stripping off the protocol, it's `'http'` on my
 install. Before [21734], however, it used to be `'https'` in this case.

 In [21734], scheme calculation was removed from `get_site_url()`, but not
 from `get_home_url()`, which is used for "Visit Site" link in the toolbar.

 [attachment:20759.3.diff] brings consistency and fixes the issue with
 "Visit Site" link in my testing.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20759#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software