[wp-trac] [WordPress Trac] #16416: Settings -> Privacy "block search engines" option is not accurate
WordPress Trac
wp-trac at lists.automattic.com
Thu Sep 13 17:43:34 UTC 2012
#16416: Settings -> Privacy "block search engines" option is not accurate
-----------------------------------+-----------------------
Reporter: designsimply | Owner: westi
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 3.5
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch ux-feedback |
-----------------------------------+-----------------------
Comment (by nacin):
I wanted to get this in. What still needs review after [21838] —
* The text/language in general.
* Whether we can invert the checkbox, as the options for language is
better when inverted. I think we can get away with this if we set
value="0" on the box and then in sanitize_option() convert === null to 1.
(As options.php uses 'null' when nothing is posted... The fix in [21292]
makes this actually distinguishable now.)
* Whether we should register this whole option using
add_settings_field(), to hypothetically allow it to be unhooked. Note that
there's no actual API for removing fields and sections, but I'd consider
that to be good enough for now. Note also #21507.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16416#comment:37>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list