[wp-trac] [WordPress Trac] #6821: ImageMagick support

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 7 22:30:16 UTC 2012


#6821: ImageMagick support
-------------------------------------+-----------------------
 Reporter:  matt                     |       Owner:
     Type:  task (blessed)           |      Status:  assigned
 Priority:  normal                   |   Milestone:  3.5
Component:  Upload                   |     Version:  2.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+-----------------------

Comment (by scribu):

 Conclusions from IRC discussion:

 * the WP_Image_Editor class should just be a function, or be merged with
 WP_Image_Editor_Base
 * the wp-includes/editors directory is unnecessary
 * add abstract make_image() method in the base class, if it's a public
 method, so that all implementations have it

 Undecided:

 * rename WP_Image_Editor to WP_Image_For_Editing; what do we call the
 implementation classes then?
 * use encapsulation instead of inheritance, i.e. WP_Image_For_Editing
 contains a reference to a particular implementation class

 My question:

 * do we really need both `'wp_editor_use_' . $editor` AND
 'image_editor_class' hooks?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/6821#comment:63>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list