[wp-trac] [WordPress Trac] #21391: Move attachment editing (media.php) to use standard post type UI

[WordPress Trac]

#21391: Move attachment editing (media.php) to use standard post type UI
----------------------------+------------------
 Reporter:  nacin           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.5
Component:  Media           |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by helenyhou):

 Finally have a first pass: [attachment:21391.2.diff], worked on with
 ocean90.

 Does the following:

 * Exposes the regular post edit screen for attachments, which comes with
 goodies like visual editor for the description, slug editing (works!),
 taxonomy metaboxes (works!), and any other metaboxes
 * Adds the image thumbnail with in-place image editing, currently above
 the title (not beautiful, but works!)
 * Adds a metabox for editing alt text, caption (really the excerpt), and
 displaying the file URL
 * Introduces `disable_for_post_type()` and `post_type_disables()`.
 Currently utilized in the publish metabox
 * Adds hooks to edit_form_advanced.php

 Known issues:

 * "Trash" in the publish metabox should really be "Delete Permanently" (or
 rather, based on the MEDIA_TRASH internal constant like it is elsewhere)
 * Alt text shows but doesn't actually save
 * The layout of the screen isn't awesome, at all. In particular, the
 placement of the image+details+editor at the top doesn't look great with
 the publish metabox still at the top of the side metaboxes. Also, it does
 feel a little clunky to have the title and description edited separately
 from the other pieces of data, when they were formerly indicated as being
 essentially equal in importance, and realistically the alt text and
 caption are perhaps more important.

 Things to think about:

 * What happens when you add new media via media-new.php? Upload and then
 punt over to editing it immediately? Something else?
 * Do we want to expose attached status (parent post) on the screen
 somewhere? It is on the list table, so it's not lost.
 * Should we leave the list table where it is (a special upload.php screen)
 or move to the `/wp-admin/edit.php?post_type=attachment` screen instead?

 I'm sure there's more. :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21391#comment:27>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software