[wp-trac] [WordPress Trac] #21749: Wrong URL for theme screenshot

WordPress Trac wp-trac at lists.automattic.com
Mon Sep 3 21:34:36 UTC 2012


#21749: Wrong URL for theme screenshot
--------------------------+--------------------
 Reporter:  pavelevap     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4.2
Component:  Themes        |     Version:  3.4.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by nacin):

 get_stylesheet_directory_uri() and get_template_directory_uri() have
 always been this way. I want to think about what could break if we change
 that now. On the other hand, we should be able to make some changes to
 WP_Theme.

 [attachment:21749.3.patch] is a good start, though Live Preview and
 Preview links remain broken. We can fix that with a change in the list
 table and in wp_customize_url(). It looks like the preview output buffer
 on the frontend still fails due to spaces not being allowed in the regex
 in preview_theme(). That's a long-standing bug, though.

 Looking to do some unit tests for this, then run with it.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21749#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list