[wp-trac] [WordPress Trac] #22307: Twenty Twelve: JavaScript error if navigation wrapper markup is removed from header

WordPress Trac noreply at wordpress.org
Wed Oct 31 19:41:49 UTC 2012


#22307: Twenty Twelve: JavaScript error if navigation wrapper markup is removed
from header
---------------------------+------------------
 Reporter:  sswells        |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------

Comment (by DrewAPicture):

 Replying to [comment:18 obenland]:
 > Replying to [comment:17 DrewAPicture]:
 > > IMHO, all of the edge cases are outside the point.
 >
 > You consider removing the menu markup and neglecting to dequeue the
 script not an edge case?

 I consider graceful error-handling to be the point of the discussion.

 It's always been my impression that in order to promote best-practice, you
 have to actually practice best-practice. I think this may be the first
 time I've ever seen an argument ''against'' graceful error-handling. My
 position hasn't changed and I'm starting to repeat myself: Either make the
 error helpful or add the null check and don't show it at all.

 I've made my points, take from them what you will.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22307#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list