[wp-trac] [WordPress Trac] #22307: Twenty Twelve: JavaScript error if navigation wrapper markup is removed from header
WordPress Trac
noreply at wordpress.org
Tue Oct 30 20:13:01 UTC 2012
#22307: Twenty Twelve: JavaScript error if navigation wrapper markup is removed
from header
---------------------------+------------------
Reporter: sswells | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.5
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch |
---------------------------+------------------
Comment (by DrewAPicture):
Replying to [comment:10 obenland]:
> As far as I'm concerned, this includes plugins. You can't expect the
theme to handle changes caused by a third party.
I think this is a very valid point and it underscores that in this case,
the plugin is modifying theme behavior and not core behavior, which the
theme shouldn't have to support, parent or not.
That said, it might be worth throwing a more helpful error of the
`_doing_it_wrong()` variety instead just bailing as proposed in
[attachment:22307.diff].
--
Ticket URL: <http://core.trac.wordpress.org/ticket/22307#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list