[wp-trac] [WordPress Trac] #22287: Plugin in another plugin folder causes Activate link to be wrong on Download

[WordPress Trac]

#22287: Plugin in another plugin folder causes Activate link to be wrong on
Download
-----------------------------+--------------------------
 Reporter:  joehoyle         |       Type:  defect (bug)
   Status:  new              |   Priority:  normal
Milestone:  Awaiting Review  |  Component:  Plugins
  Version:  trunk            |   Severity:  normal
 Keywords:                   |
-----------------------------+--------------------------
 I am not sure if shipping a plugin within another plugin is officially
 supported, but there is an inconsistency between the activate links in the
 Manage Plugins page, and the Activate Plugin on the Plugin Downloaded
 success page.

 This is because on the Manage Plugins page, the `get_plugins()` is going
 to scan the plugins dir and all dirs within it, however, on the Upgrade
 page, it calls `get_plugins()` specifying the plugin dir as the base (see
 https://github.com/WordPress/WordPress/blob/master/wp-admin/includes
 /class-wp-upgrader.php#L579)

 That will cause the "embedded" plugin to be picked up, and if it's
 alphabetically above the main plugin file (presumably) see code comment "
 //Assume the requested plugin is the first in the list"

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22287>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software