[wp-trac] [WordPress Trac] #22260: Incorrect sprintf replacement specifiers

[WordPress Trac]

#22260: Incorrect sprintf replacement specifiers
-------------------+--------------------------
 Reporter:  westi  |       Type:  defect (bug)
   Status:  new    |   Priority:  normal
Milestone:  3.5    |  Component:  I18N
  Version:  3.4.2  |   Severity:  normal
 Keywords:         |
-------------------+--------------------------
 We have a number of places in core where we are incorrectly using
 '''%1s''' instead of '''%1$s''' while this doesn't break the functionality
 of the code it does have the potential to lead to incorrect translations
 if the i18n teams re-order the replacements buy don't know to insert the
 missing '''$'''.

 This is because without the '''$''' we are specifying the minimum with of
 the replacement rather than a numbered replacement.

 From http://uk.php.net/sprintf:

   An optional number, a width specifier that says how many characters
 (minimum) this conversion should result in.

 We need to review the following and fix them as appropriate:

  * wp-admin/includes/ms.php:409
  * wp-admin/network/site-new.php:88
  * wp-admin/users.php:232
  * wp-admin/users.php:234
  * wp-admin/users.php:333
  * wp-admin/users.php:335
  * wp-admin/users.php:337
  * wp-includes/ms-functions.php:1018
  * wp-includes/ms-functions.php:1053

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22260>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software