[wp-trac] [WordPress Trac] #22164: Move comment "keyboard shortcuts" setting to comments -> screen options
WordPress Trac
wp-trac at lists.automattic.com
Sun Oct 14 16:31:34 UTC 2012
#22164: Move comment "keyboard shortcuts" setting to comments -> screen options
-------------------------+-----------------------------
Reporter: lessbloat | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Comments | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+-----------------------------
Comment (by nacin):
Played around with this today a bit. A few things:
1) Keyboard shortcuts should live-toggle based on the state of the
checkbox.
2) I can't get $.hotkeys.remove() to work, as I think it tries to reach
into long-gone jQuery internals. When looking into that, our jQuery
Hotkeys plugin is terribly out of date. It is beta 2, by beta 7, it was
completely rewritten, and then 3 years ago, Resig rewrote it:
https://github.com/jeresig/jquery.hotkeys. If we can't hack in a fix to
hotkeys, in order to update hotkeys, we'll need to rewrite our
table_hotkeys.
I started on the front-end, while Sergey handled the backend. If we can
work out how to remove events, we should be able to combine both patches.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/22164#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list