[wp-trac] [WordPress Trac] #22044: Twenty Twelve: Support Media Queries on IE7/8 (don't use mobile menu)
WordPress Trac
wp-trac at lists.automattic.com
Mon Oct 1 21:45:13 UTC 2012
#22044: Twenty Twelve: Support Media Queries on IE7/8 (don't use mobile menu)
---------------------------+--------------------
Reporter: bpetty | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.5
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch |
---------------------------+--------------------
Comment (by bpetty):
Replying to [comment:14 Ov3rfly]:
> Replying to [comment:13 bpetty]:
> > Anyway, the point is that you can still do anything and everything
@import does without actually using @import inside child themes.
>
> All child themes I ever saw use @import for parent style.css as
explained in
[http://codex.wordpress.org/Child_Themes#Example_of_a_basic_Child_Theme
Codex].
>
> That's why the use of ''respond.js'' is no solution to the IE7/8 menu
problem.
It's a new theme, not an upgrade to Twenty Eleven, so there are almost
zero child themes for this change to even break. There might be a few
child themes created in the last couple days based on a download from the
theme repository, and even then, adding this patch won't actually break
any of them that aren't already broken, it just might not actually fix
this bug if they are using @import. It won't break @import though.
I agree that it's a hack, and I don't like it anymore than you do. As I
pointed out when I opened the ticket, this is a last resort since the
appropriate fix (that you agree is the appropriate fix) of re-organizing
the media query styles is impossible at this point. It would require a new
round of testing past the time it would take to actually get it re-
organized that would have to push it back to being released with WordPress
3.6. That's not going to happen.
There is nothing else we can do at this point except make use of the
Respond.js hack to get this fixed for IE8. It's either that, or nothing.
> It's just a bad hack which will cause even more bad hacks, as writing
real-world compatible child themes for Twenty Twelve will not be possible
and everybody will have to directly edit the main Twenty Twelve to include
their styles and code. This will cause a lot of confusion and probably
messed up and buggy themes with bad user experience.
No, no-one will have to touch Twenty Twelve at all. The addition of
Respond.js won't change that at all, and yes, even with this, the
recommended way of making modifications to a theme is still to use a child
theme.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/22044#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list