[wp-trac] [WordPress Trac] #22581: Admin CSS Changes Affected Buttons

[WordPress Trac]

#22581: Admin CSS Changes Affected Buttons
-----------------------------+----------------------------
 Reporter:  usermrpapa       |       Type:  defect (bug)
   Status:  new              |   Priority:  normal
Milestone:  Awaiting Review  |  Component:  Administration
  Version:  trunk            |   Severity:  normal
 Keywords:                   |
-----------------------------+----------------------------
 Per discussion with Nacin over Twitter (times have changed), he asked that
 I open this ticket....

 3.5 admin css changes had an affect on our buttons (form submits) used
 within the admins (within our plugin).  Basically, the changes forced our
 buttons to go from being primary buttons to secondary buttons.

 Three images attached.  The 3.4.2-buttons.png image is what our buttons
 looked like in 3.4.2.  The 3.5-buttons-before.png image is what they
 changed to look like while running the 3.5 trunk. tthe 3.5-buttons-
 after.png image is what they look like now after our code changes. Please
 note, we are are not currently using submit_button().

 Also, worth mentioning that the 3.5-buttons-before.png image buttons do
 turn 'blue' (primary looking) on hover.

 Our current released code for that generated the 3.4.2 button is:

 {{{
 <input id="saveit" class="button button-primary" type="submit"
 value="Update Global Options" name="saveit">
 }}}

 the change to our code we have made for 3.5 to get them back to primary
 is:

 {{{
 <input id="saveit" class="button-primary" type="submit" value="Update
 Global Options" name="saveit">
 }}}

 Perhaps the use of button and button-primary together was not correct, but
 it worked before and Nacin wanted a ticket to look into since it might
 affect other plugins.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22581>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software