[wp-trac] [WordPress Trac] #22541: Media icon doesn't work in distraction free writing mode

WordPress Trac noreply at wordpress.org
Sat Nov 24 10:34:22 UTC 2012


#22541: Media icon doesn't work in distraction free writing mode
--------------------------+--------------------
 Reporter:  ericmann      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.5
Component:  Media         |     Version:  trunk
 Severity:  blocker       |  Resolution:
 Keywords:  needs-patch   |
--------------------------+--------------------

Comment (by azaozz):

 22541.patch seems to work but needs some more testing (only did quick
 test) and is kind of hacky.

 We can add the `insert-media` class to DFW's media button as the original
 event is attached to the body or even have a one-line method to open the
 modal that can be called with `onclick`, etc.

 However the original button also has `data-editor="..."` which would be
 harder to set in these cases. Not sure why it's there, seems
 `wpActiveEditor` can be used instead.

 cc: koopersmith

 Replying to [comment:4 nacin]:

 We could use the old class on the link which would keep any JS accessing
 it that way working. Think `.insert-media` was needed as the UI changed
 from a link to a button.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22541#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list