[wp-trac] [WordPress Trac] #22547: Thumbnail not shown when uploading a single image in media-new.php
WordPress Trac
noreply at wordpress.org
Sat Nov 24 02:11:09 UTC 2012
#22547: Thumbnail not shown when uploading a single image in media-new.php
--------------------------+--------------------
Reporter: scribu | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.5
Component: Media | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+--------------------
Changes (by nacin):
* keywords: => has-patch
Comment:
I tried really hard to avoid touching handlers.js in [22755] and related
changesets. I did realize that updateMediaForm() had the potential to
cause problems, but I thought I had worked around them (and clearly
didn't).
The reason is we did a lot of research in the 3.5 cycle for how plugins
were using existing code, but we didn't look into handlers.js. That's
because we're no longer using handlers.js outside of media-new.php. The
new dialog uses the newer, not-terrible Plupload bridge added for the
customizer in 3.4. I don't really know how people are using handlers.js —
I hope none of them are, but I'd rather leave it alone until 3.6.
Now that I've explained the background, it does look like
updateMediaForm() is completely useless for the form, and the side effects
of just removing the whole function would be fairly minimal. So this patch
is good.
I wouldn't mind a CSS-only patch though.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/22547#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list