[wp-trac] [WordPress Trac] #21990: SimplePie: DOMDocument can be disabled

[WordPress Trac]

#21990: SimplePie: DOMDocument can be disabled
------------------------------------------+--------------------------
 Reporter:  nacin                         |       Owner:  markjaquith
     Type:  defect (bug)                  |      Status:  assigned
 Priority:  low                           |   Milestone:  3.5
Component:  External Libraries            |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  needs-unit-tests needs-patch  |
------------------------------------------+--------------------------
Changes (by rmccue):

 * keywords:  has-patch needs-testing needs-unit-tests => needs-unit-tests
     needs-patch


Comment:

 Replying to [comment:19 nacin]:
 > We still need to update SimplePie core to avoid calling DOMDocument when
 it is not available. A plugin using SimplePie directly (thus sidestepping
 fetch_feed()) will not be able to rely on kses, but they should still be
 given an opportunity to avoid the fatal error. My suggestion would be to
 pass an error back up the stack (if that makes sense — I'm not that
 familiar with SP) or just return `''`, as rmccue and I had discussed.

 Due to the nature of `SimplePie::sanitize()`, passing up the stack is best
 done by throwing an exception where needed. To ensure API compatibility,
 that'll need to be shielded from the end-user, but in the next major
 version, they'll have the ability to get those exceptions themselves. I
 know how I'm going to fix this, so I'll get that patched upstream ASAP.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21990#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software