[wp-trac] [WordPress Trac] #22456: Audit the admin with JavaScript off

[WordPress Trac]

#22456: Audit the admin with JavaScript off
------------------------------------+---------------------
 Reporter:  nacin                   |       Owner:  nacin
     Type:  defect (bug)            |      Status:  closed
 Priority:  normal                  |   Milestone:  3.5
Component:  Accessibility           |     Version:
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  audit has-patch commit  |
------------------------------------+---------------------

Comment (by nacin):

 > If you use .hide-if-no-js, then devs have to add that class to their
 markup as well, even if using the core-defined column callback (which is
 where the .check-column class comes from). Also, the updates screen uses
 these select all checkboxes, which were not accounted for in earlier
 patches, but are taken care of with this method.

 It's also worth pointing out a few things here:
  * It is hypothetically possible to implement "check all" server side, but
 no one sane would probably do that (for both technical and UX reasons), so
 this seems fine and good that it carries to other forms.
  * The only <input type="checkbox"> that would have needed to be modified
 is the one in WP_List_Table. That one overrides all over 'cb' columns to
 add some accessibility pieces. The remaining '<input type="checkbox" />'
 strings are placeholders as of 3.5.
  * .hide-if-no-js is a nice tool, yes, and it has its uses. But it doesn't
 beat well-organized CSS. You'll note that in [22719] I took pains to group
 pieces of CSS with their sections (which isn't what the patch you reviewed
 did). That makes it very obvious what is going on — and is a better heads-
 up when you are editing CSS, making it easier to maintain.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22456#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software