[wp-trac] [WordPress Trac] #22356: Deprecate gd_edit_image_support() and replace it with a better method
WordPress Trac
noreply at wordpress.org
Tue Nov 20 19:08:37 UTC 2012
#22356: Deprecate gd_edit_image_support() and replace it with a better method
--------------------------+--------------------------
Reporter: markoheijnen | Owner: DH-Shredder
Type: enhancement | Status: assigned
Priority: normal | Milestone: 3.5
Component: Media | Version: trunk
Severity: normal | Resolution:
Keywords: |
--------------------------+--------------------------
Comment (by DH-Shredder):
At the very least, I'll do a simplification run on those functions, and
see if anything else can be combined.
Indeed, I don't think this is currently optimal either, it's just
complicated if we want to avoid code duplication.
If it's the general consensus that it'd be more straight forward, we can
also do a base WP_Image_Editor::supports_mime_type() (rather than
supports).
It'd just have the issues mentioned in IRC regarding confusion if an
Editor author doesn't override (since it could return true, but for a
different Editor), and also would still leave authors without a way to
check if there is an Editor that both supports the mime and the methods
(without just running get_instance() and checking for failure).
--
Ticket URL: <http://core.trac.wordpress.org/ticket/22356#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list