[wp-trac] [WordPress Trac] #18977: Make import.php dynamic

[WordPress Trac]

#18977: Make import.php dynamic
----------------------------+-----------------------
 Reporter:  jane            |       Owner:  nacin
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  3.5
Component:  Import          |     Version:  3.3
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+-----------------------

Comment (by dllh):

 I've added a new patch with the following modifications from the last:

 * Sets {{{$popular_importers}}} to false instead of unsetting it.
 * Checks for {{{is_array( $popular_importers)}}} rather than just testing
 for existence.

 I think this fixes the potential notice issue and is more
 consistent/robust; that is, if we're checking for an array in the one
 place, we should do the same below. This safeguards against the unlikely
 case that something else (a plugin, say) writes some non-array garbage
 into the transient.

 I suppose that if we wanted to be extra robust, we'd also check for
 {{{$popular_importers['importers']}}}, but maybe that's overkill.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18977#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software