[wp-trac] [WordPress Trac] #20469: Twenty Eleven: better closed comments notes

[WordPress Trac]

#20469: Twenty Eleven: better closed comments notes
---------------------------+---------------------------
 Reporter:  iandstewart    |       Owner:  lancewillett
     Type:  enhancement    |      Status:  reopened
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:  3.4
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+---------------------------

Comment (by kovshenin):

 In [attachment:20469.diff]:

 * Checks `get_comments_number()` instead of using `$comments_by_type` in
 Twenty Eleven and Twenty Twelve, added `get_comments_number()` to Twenty
 Ten.
 * Loads the comments template in Twenty Twelve's single.php regardless of
 whether they're open or closed (consistent with page.php)
 * In Twenty Ten, moved the "Comments closed" block outside the `!
 have_comments()` condition.

 Also, for some reason, Twenty Ten defines the following styles:

 {{{
 .nopassword,
 .nocomments {
         display: none;
 }
 }}}

 Which makes the "comments closed" and "password protected" messages
 invisible. Not sure why it's doing it, but it doesn't feel safe to remove
 it. `nocomments` was invisible since the first import, `nopassword` was
 added in [15125] with a good reason.

 Thoughts?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20469#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software