[wp-trac] [WordPress Trac] #20469: Twenty Eleven: better closed comments notes

[WordPress Trac]

#20469: Twenty Eleven: better closed comments notes
---------------------------+---------------------------
 Reporter:  iandstewart    |       Owner:  lancewillett
     Type:  enhancement    |      Status:  reopened
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:  3.4
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+---------------------------
Changes (by kovshenin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 My original concern was with:

 {{{
 'open' == get_option( 'default_comment_status' )
 }}}

 I'm okay with [22587] and [22588], but I agree `$comments_by_type` is not
 great for a default theme. I think we should replace that with
 `get_comments_number`, and also treat it as an int, not a string as in
 prior to [22587]. Patch incoming.

 I also agree that displaying "Comments are closed" on a page with closed
 comments but with one or more pingbacks is a little weird too, but not
 really sure what can be done about that, since a pingback is essentially a
 comment, or a "thought" as we describe in some of the themes. We could
 also make use of `pings_open()` or maybe add an argument to
 `get_comments_number()` where we could specify the type of comments we
 want the number for, and use `separate_comments` internally. I don't know,
 pings are confusing, let's just deprecate them :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20469#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software