[wp-trac] [WordPress Trac] #6821: ImageMagick support
WordPress Trac
noreply at wordpress.org
Wed Nov 14 21:31:42 UTC 2012
#6821: ImageMagick support
-------------------------------------+-----------------------
Reporter: matt | Owner:
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 3.5
Component: Upload | Version: 2.5
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+-----------------------
Comment (by DH-Shredder):
Had a few comments from others regarding their dislike for removing the
abstract class definitions in [22510]
The arguments amounted to a few things:
- We're no longer enforcing the proper parameters on the required methods
for default editors
- The definition of an "editor" is a lot less strict, calling into
question if there's too much flexibility in this model
- New users of WP_Image_Editor won't have auto-complete or PHPDoc for the
new default methods
It's been noted that while we can't add abstract classes in the future
(which was part of the reason for the change) that we *can* remove them in
the future, giving us time for a perhaps better solution.
I'm on the fence on this -- I think that the current setup gives a ton
more flexibility to plugin developers (in terms of not having to create an
entire Image Editor for a basic feature), but the above criticisms are
valid.
Questions, comments, concerns? Maybe those concerned can pop in and
expand if I misrepresented your argument?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/6821#comment:113>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list