[wp-trac] [WordPress Trac] #21206: Replace Farbtastic color picker
WordPress Trac
noreply at wordpress.org
Fri Nov 9 18:09:51 UTC 2012
#21206: Replace Farbtastic color picker
----------------------------+---------------------
Reporter: lessbloat | Owner: nacin
Type: task (blessed) | Status: closed
Priority: normal | Milestone: 3.5
Component: UI | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch |
----------------------------+---------------------
Comment (by mattwiebe):
Replying to [comment:88 johnbillion]:
> Any reason the picker appears inline (and pushes the 'Save Changes'
button down when opened) instead of floating above the page content like
the current (3.4) picker?
I guess you're looking at the Custom Background picker? Anyway,
wpColorPicker follows on the inline style that we had for Farbtastic in
the Customizer. We previously had multiple implementations of Farbtastic
integration, now we have a single, unified one. Since the Customizer is
going to be the residence of most color pickers going forward, that's the
style to use.
Also: floating panels are a pain in the butt. Calculating positions,
making sure you don't wind up offscreen, not obscuring needed content...
Leave it to the browser.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/21206#comment:89>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list