[wp-trac] [WordPress Trac] #22215: Customizer Custom Background does not set context

WordPress Trac noreply at wordpress.org
Fri Nov 9 02:58:39 UTC 2012


#22215: Customizer Custom Background does not set context
------------------------------+------------------
 Reporter:  kovshenin         |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  high              |   Milestone:  3.5
Component:  Appearance        |     Version:  3.4
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------
Changes (by koopersmith):

 * keywords:  has-patch => has-patch commit


Comment:

 +1

 Replying to [comment:2 kovshenin]:
 > In [http://core.trac.wordpress.org/attachment/ticket/22215/22215.diff
 22215.diff] removing the use of `this.uploader.supported` which apparently
 is empty at that stage, and not using the `control.uploader.param`
 function, which is not defined when that code runs. Using a
 `control.uploader.params` object directly which is passed to the Uploader
 when it's created. Not entirely sure this is the right approach to solve
 this, feedback appreciated.

 This is exactly the right approach to solve this. Since the `wp.Uploader`
 instance is created right after this code runs, we should use the `params`
 key (which you correctly did) instead of trying to use the `wp.Uploader`
 methods.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22215#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list