[wp-trac] [WordPress Trac] #21390: Upload/Insert media revamp

WordPress Trac noreply at wordpress.org
Thu Nov 8 14:15:10 UTC 2012


#21390: Upload/Insert media revamp
----------------------------+--------------------------
 Reporter:  nacin           |       Owner:  koopersmith
     Type:  task (blessed)  |      Status:  accepted
 Priority:  high            |   Milestone:  3.5
Component:  Media           |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+--------------------------

Comment (by koopersmith):

 In [changeset:"22466"]:
 {{{
 #!CommitTicketReference repository="" revision="22466"
 Media: Improve sidebar handling and make attachment display properties
 attachment-specific.

 `wp.mce.media`
 * Watch all workflows for the `insert` event and attempt to insert the
 current state's `selection` if it exists.
 * Fetch and pass attachment display properties through to
 `wp.media.string.image()`.

 `wp.media.controller.Region`
 * Separate the concept of events and modes.
 * All events triggered on a `Region` trigger both `event` and `event:mode`
 callbacks.
 * When a mode is deactivated, `deactivate` and `deactivate:mode` events
 are fired.
 * When a mode is activated, `activate` and `activate:mode` events are
 fired.

 `wp.media.controller.Library`
 * Remove the `details()`, `buildDetails()`, and `clearDetails()` methods
 that juggled sidebar views. Instead, handle the sidebar views using modes.

 `wp.media.controller.Gallery`
 * Shift the overloaded `sidebar()` method to use modes.

 `wp.media.view.MediaFrame.Post`
 * Declare `activate:mode` event bindings using an nested object to reduce
 repetition.
 * Update sidebar activation callbacks.

 `wp.media.view.Settings`
 * Refactor to leverage HTML data attributes and implicit values (instead
 of setting the fallback whenever an object was created). This has the
 additional benefit that gallery shortcode parameters are not output when
 the user has left them set to the default.

 see #21390.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21390#comment:49>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list