[wp-trac] [WordPress Trac] #21167: Problem with custom permalinks

WordPress Trac noreply at wordpress.org
Mon Nov 5 14:48:58 UTC 2012


#21167: Problem with custom permalinks
------------------------------+-----------------------
 Reporter:  kaffeeringe       |       Owner:
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  3.5
Component:  Permalinks        |     Version:  3.4
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------
Changes (by xknown):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 The fix is probably incomplete. We should be passing the second argument
 on preg_quote and use the same delimiter where rewrite rules are being
 used.

 For example, having the following permalink structure "/%post_id%#foo"
 (yes, probably unrealistic) would produce an invalid regular expression in
 wp-includes/class-wp.php, where # is used as a delimiter.
 http://core.trac.wordpress.org/browser/trunk/wp-includes/rewrite.php#L344
 http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp.php#L204

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21167#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list