[wp-trac] [WordPress Trac] #20902: redirect_canonical() on using permalink: Not all $_GET being redirected

[WordPress Trac]

#20902: redirect_canonical() on using permalink: Not all $_GET being redirected
-------------------------------------------------+-------------------------
 Reporter:  arieputranto                         |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Canonical                            |  Review
 Severity:  normal                               |     Version:  3.4
 Keywords:  has-patch needs-testing dev-         |  Resolution:
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by kovshenin):

 * keywords:  needs-patch => has-patch needs-testing dev-feedback


Comment:

 [attachment:20920.diff] fixes all three scenarios, mainly by adding logic
 to `canonical.php`. As for the post format canonical redirects, the
 current tax query redirects seems to handle tags, categories and custom
 taxonomy well, but the extra `post_type` query argument added in
 `_post_format_request` prevented it from doing so.

 I feel weird that categories, tags and custom post types won't append the
 `post_type` argument, even if added to other object types with
 `register_taxonomy_for_object_type`, so I don't understand the reason why
 it's there for post formats, since post formats is a taxonomy, just like
 everything else, except that it has a custom admin interface. Would like
 feedback on this from Andrew and/or Mark, see [17249].

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20902#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software