[wp-trac] [WordPress Trac] #20657: Custom Header Image Cropping deletes header images

[WordPress Trac]

#20657: Custom Header Image Cropping deletes header images
--------------------------+-----------------------
 Reporter:  westi         |       Owner:  ryan
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  3.4
Component:  Appearance    |     Version:  3.4
 Severity:  blocker       |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by ryan):

 Replying to [comment:21 SergeyBiryukov]:
 > Replying to [comment:20 ryan]:
 > > When uploading an image and then using that image as is with no
 cropping, is _copy_image_file() necessary?
 >
 > I guess so. Otherwise `_wp_attachment_is_custom_header` could be
 overwritten by another theme, as you mentioned in comment:14.

 Seems like that path (upload new image from custom header page and skip
 cropping) creates an attachment with the uploaded image, copies the image
 in that attachment, updates the attachment with the copied image, and then
 deletes the original image. The original image and the copy are identical
 all the way through.

 Probably not worth worrying with, but I  want to make sure I'm
 understanding all of the different paths through this code.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20657#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software