[wp-trac] [WordPress Trac] #20603: Warning error occurs on the default parameter of "admin-head-callback" in add_theme_support.

WordPress Trac wp-trac at lists.automattic.com
Thu May 3 07:38:33 UTC 2012


#20603: Warning error occurs on the default parameter of "admin-head-callback" in
add_theme_support.
--------------------------+-----------------------
 Reporter:  jim912        |       Owner:  nacin
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  3.4
Component:  Themes        |     Version:  3.4
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------
Changes (by westi):

 * priority:  normal => high
 * status:  closed => reopened
 * resolution:  fixed =>
 * severity:  normal => major


Comment:

 This change breaks backwards compatibility with themes that call
 {{{add_custom_image_header()}}} with an empty {{{wp_head_callback}}} which
 was previously quite valid.

 In 3.3 we only added the hook onto wp_head if it wasn't empty.

 With the change Custom Headers become disabled on all themes that don't
 need a wp_head callback which is a regression.

 I think we can just revert the changes to wp-includes/theme.php

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20603#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list