[wp-trac] [WordPress Trac] #20161: Move Toolbar rendering in the admin to the header

WordPress Trac wp-trac at lists.automattic.com
Fri Mar 30 15:11:43 UTC 2012


#20161: Move Toolbar rendering in the admin to the header
-------------------------+---------------------
 Reporter:  nacin        |       Owner:  nacin
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  3.4
Component:  Toolbar      |     Version:
 Severity:  normal       |  Resolution:  fixed
 Keywords:               |
-------------------------+---------------------

Comment (by nacin):

 Replying to [comment:6 johnbillion]:
 > Replying to [comment:5 nacin]:
 > > That data is going to be inaccurate anyway, as the pageload wasn't
 allowed to finish before collecting that data.
 > This is actually intentional. The plugin hooks onto `wp_footer()` and
 `admin_footer()` at a priority of 999 so it gathers its data and adds its
 menus just before the admin bar is rendered (at priority 1000). This way
 the data it displays is exclusive of the overhead of the admin bar and
 more representative of a page load for non-logged-in users (which is what
 I'm interested in seeing).
 >
 > Anyway, this changeset isn't a problem now because I've implemented a
 JS-based solution similar to yours.

 I would agree that is intentional behavior.

 At the very least, http://plugins.trac.wordpress.org/changeset/525389
 /debug-bar/ returns the panels to wp_footer and admin_footer at priority
 1000. So everything but changing a label in the toolbar should work as
 normal.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20161#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list