[wp-trac] [WordPress Trac] #20331: Expire WP_Theme cache on updates and theme edits

[WordPress Trac]

#20331: Expire WP_Theme cache on updates and theme edits
--------------------------+------------------
 Reporter:  nacin         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4
Component:  Themes        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------

Old description:

> When saving a file in wp-admin/theme-editor.php, we should force a cache
> delete.
>
> Additionally, cache deletes should occur when an update occurs. Otherwise
> we may be reading old Version numbers from disk.
>
> When deleting the cache, we will need to refresh the headers that exist
> in the current object instance. A simple $this->__construct() can re-
> initialize everything. This will enable us to call $theme->cache_delete()
> at any time to force fresh information.

New description:

 When saving a file in wp-admin/theme-editor.php, we should force a cache
 delete.

 Additionally, cache deletes should occur when an update occurs. Otherwise
 we may be reading old Version numbers from disk.

 When deleting the cache, we will need to refresh the headers that exist in
 the current object instance. A simple `$this->__construct()` can re-
 initialize everything. This will enable us to call $theme->cache_delete()
 at any time to force fresh information.

--

Comment (by nacin):

 Also, the timeout of 7200 is a bit too long. This was chosen as it was the
 timeout for theme roots in an earlier version. We can drop that to 1800
 without any issues. WP.com uses something even smaller like 300.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20331#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software