[wp-trac] [WordPress Trac] #11216: Support page templates located in a subdirectory of the theme
WordPress Trac
wp-trac at lists.automattic.com
Thu Mar 29 18:45:00 UTC 2012
#11216: Support page templates located in a subdirectory of the theme
-------------------------------------+---------------------
Reporter: westi | Owner: nacin
Type: enhancement | Status: closed
Priority: normal | Milestone: 3.4
Component: Themes | Version: 2.9
Severity: normal | Resolution: fixed
Keywords: has-patch needs-testing |
-------------------------------------+---------------------
Comment (by nacin):
Replying to [comment:18 toscho]:
> There are some methods with `@access public` in PHPDoc while their
visibility is set to `private`: `_name_sort()`, `_name_sort_i18n()` and
`scandir()`.
>
> I think `@access` is obsolete when a visibility keyword is used in the
method declaration.
I think I am going to make scandir() private, but _name_sort() and
_name_sort_i18n() are public only because they are used as a callback.
Their usage is private. Hence @access private.
You're probably right about @access not being necessary when a visibility
keyword is in play. However, @access private specifically hides it from
phpdocumentor and I am wondering if it overrides a visibility keyword.
Happy to remove @access private, and make scandir() private. New ticket?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11216#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list