[wp-trac] [WordPress Trac] #19840: Select custom header or background images from media library

WordPress Trac wp-trac at lists.automattic.com
Sun Mar 25 21:51:33 UTC 2012


#19840: Select custom header or background images from media library
-------------------------------------+------------------
 Reporter:  jane                     |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  3.4
Component:  Media                    |     Version:  3.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Old description:

> In a recent version, we made it so uploaded custom header images get
> saved in the media library. Awesome! Next step: on the custom header and
> background screens, we need an option to choose an image from the media
> library. UI-wise, should just be an option next to the select/upload
> line. Should be implemented on both screens.

New description:

 In a recent version, we made it so uploaded custom header images get saved
 in the media library. Awesome! Next step: on the custom header and
 background screens, we need an option to choose an image from the media
 library. UI-wise, should just be an option next to the select/upload line.
 Should be implemented on both screens. The fix was to make `step()` nonce-
 aware so it could better return the proper step.

--

Comment (by aaroncampbell):

 [attachment:19840.13.diff] fixes an issue with the custom headers page.
 If you let the nonce expire and refreshed on step 2 or 3, it would load
 step 1.  However, since step=2/3 was still in the URL the proper JS wasn't
 loaded and the "choose from image library" link stopped working.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19840#comment:28>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list