[wp-trac] [WordPress Trac] #20288: Missing bottom border for bulk-actions checkbox th in wp-posts-list-table if current user can't "edit_post".

WordPress Trac wp-trac at lists.automattic.com
Fri Mar 23 15:27:46 UTC 2012


#20288: Missing bottom border for bulk-actions checkbox th in wp-posts-list-table
if current user can't "edit_post".
-------------------------+------------------------------
 Reporter:  szaqal21     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  UI           |     Version:  3.3.1
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |
-------------------------+------------------------------
Changes (by helenyhou):

 * keywords:  has-patch => needs-patch


Old description:

> If current user can't "edit_post" the bulk-actions checkbox isn't present
> but also the bottom border for th in wp-posts-list-table.
>
> I think it can be fixed by modifying line 495 in class-wp-posts-list-
> table.php like so:
>
> <th scope="row" class="check-column"><?php if ( $can_edit_post ) {
> ?><input type="checkbox" name="post[]" value="<?php the_ID(); ?>" /><?php
> } else { ?> &nbsp; <?php } ?></th>

New description:

 If current user can't "edit_post" the bulk-actions checkbox isn't present
 but also the bottom border for th in wp-posts-list-table.

 I think it can be fixed by modifying line 495 in class-wp-posts-list-
 table.php like so:

 `<th scope="row" class="check-column"><?php if ( $can_edit_post ) {
 ?><input type="checkbox" name="post[]" value="<?php the_ID(); ?>" /><?php
 } else { ?> &nbsp; <?php } ?></th>`

--

Comment:

 Patches should be made and attached as a unified diff created from root.
 Helpful links:

 [http://markjaquith.wordpress.com/2005/11/02/my-wordpress-toolbox/ Mark
 Jaquith's Unix WordPress Toolbox]

 [http://blog.ftwr.co.uk/archives/2005/11/03/windows-wordpress-toolbox/
 Peter Westwood's Windows WordPress Toolbox]

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20288#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list