[wp-trac] [WordPress Trac] #18887: Appearance -> Header UI: "Display Text" Needs Distinct theme_mod

[WordPress Trac]

#18887: Appearance -> Header UI: "Display Text" Needs Distinct theme_mod
-----------------------------+------------------
 Reporter:  chipbennett      |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  3.4
Component:  UI               |     Version:  3.2
 Severity:  minor            |  Resolution:
 Keywords:  has-patch close  |
-----------------------------+------------------
Changes (by nacin):

 * keywords:  has-patch needs-testing => has-patch close
 * milestone:  Awaiting Review => 3.4


Comment:

 get_header_textcolor() is always going to need to return 'blank' for
 compatibility reasons. I tweaked it so there is now a new function,
 display_header_text(), and I leveraged that function in core.

 However, the 'blank' checks are still in Twenty Eleven. I don't see a
 reason to go from:
 {{{
 if ( 'blank' == $text_color ) :
 }}}
 To something like:
 {{{
 if ( ( function_exists( 'display_header_text' ) && display_header_text() )
 || 'blank' == $text_color ) :
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18887#comment:28>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software