[wp-trac] [WordPress Trac] #20249: Remove custom header and background constants

Tue Mar 20 21:42:29 UTC 2012

#20249: Remove custom header and background constants
--------------------------+------------------
 Reporter:  nacin         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4
Component:  Themes        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by nacin):

 Replying to [comment:15 iandstewart]:
 > I find the callbacks, 'callback' and 'admin-header-callback', to be
 somewhat confusingly named. Of course, that could just be me. :) 'head-
 callback' and 'admin-head-callback' might be more helpful.

 I agree. I called it 'callback' because we were already using that
 internally, but we could scrap that as it wasn't behavior anyone else
 would use. (It was only used to remove the hook in
 remove_custom_image_header().)

 If I had to pick three names, it would be:
  * wp_head
  * admin_head
  * admin-preview-callback

 Obviously, those are not standardized. I could go for:
  * wp-head-callback
  * admin-head-callback
  * admin-preview-callback

 Essentially, dropping "header", as it's the admin <head>, not the header,
 and cleaning up the unsemantic admin-image-div-callback name.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20249#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software