[wp-trac] [WordPress Trac] #13429: Updating Link URL on image within Admin with Gallery

[WordPress Trac]

#13429: Updating Link URL on image within Admin with Gallery
-----------------------------------+-----------------------------
 Reporter:  vshoward               |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Future Release
Component:  Gallery                |     Version:  2.9.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+-----------------------------

Comment (by azaozz):

 Traced this back to #1870. It seems that the problem for which
 `_fix_attachment_links()` was introduced doesn't exist any more.

 Did some quick testing and don't see any problems with attachment links
 and URLs to attached files that would require them to be fixed/rewritten
 after the post is saved. Seems we can safely stop replacing the URLs.

 There is also another part to `_fix_attachment_links()`. It attaches
 orphaned attachments when they are used in a post (if the "wp-att-###" bit
 is present). This is useful for files that were uploaded directly from the
 Media -> Library screen. However we are also doing something similar while
 inserting a file into the editor (in media.php), so not sure if repeating
 it is needed.

 Overall removing `_fix_attachment_links()` seems the proper solution. This
 also improves performance while saving a post.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13429#comment:44>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software