[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General
WordPress Trac
wp-trac at lists.automattic.com
Fri Mar 9 01:17:24 UTC 2012
#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
Reporter: jane | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: 3.4
Component: Administration | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch needs-testing ux-feedback |
-------------------------------------------------+------------------
Comment (by tomauger):
Thanks Otto for cleaning up the ico2 library. It still needs a careful eye
later, but I think it's eminently workable here.
My patch re-integrates this library (this time, within favicon-
upload.php).
'''Please use DEBUG mode to leverage the JS and CSS changes''' (maybe this
is obvious and doesn't need mentioning).
In this patch:
- Uploading a PNG, JPG or GIF will function as usual. I have NOT
implemented the iframe interface in this patch
- Uploading an image that is <= 32px will result in a PASS THROUGH - the
cropping UI will be bypassed and the image will be used as-is at that
size, converted to PNG and ICO
- Uploading an ICO file will pass through if it is <= 32px. Not sure what
will happen if it's greater than 32px.
- will display only the minimum required HTML (if only a PNG is present,
will not generate the conditional IE stuff)
To DO:
- iframe crop UI
- _media_states
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:122>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list