[wp-trac] [WordPress Trac] #19840: Select custom header or background images from media library
WordPress Trac
wp-trac at lists.automattic.com
Thu Mar 8 02:58:12 UTC 2012
#19840: Select custom header or background images from media library
-------------------------------------+------------------
Reporter: jane | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.4
Component: Media | Version: 3.3
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+------------------
Comment (by sabreuse):
New issue introduced in 19840.10.diff: after the js changes in this
version, choosing a custom background image from the media library
correctly updates the background, but tb_remove() fails, and the thickbox
remains onscreen with no indication that the bg has been changed.
(I'm also confused about why this script ended up in the set-post-
thumbnail.js file -- as I understood the IRC conversation, the point was
to no longer override send_to_editor, but sticking it in a file that's not
related to backgrounds at all doesn't seem very maintainable. Was that a
mistake or am I missing some logic there?)
Confirmed that choosing a background was working as expected as of
19840.9, and that selecting a custom header works as expected in the
latest.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/19840#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list